fix(engine/rendering): Fix ChunkMeshRenderer listens to wrong deactivate event #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkWeird
added
Topic: Rendering
pollend
approved these changes
Oct 25, 2021
|
looks straightforward. |
pollend
requested changes
Oct 25, 2021
| @@ -51,7 +51,7 @@ public void onNewMesh(OnActivatedComponent event, EntityRef entity, ChunkMeshCom | |||
| disposalSet.add(new BuffersReference(mesh.mesh, disposalQueue)); | |||
| } | |||
|
|
|||
| @ReceiveEvent(components = {MeshComponent.class, LocationComponent.class}) | |||
| @ReceiveEvent(components = {ChunkMeshComponent.class, LocationComponent.class}) | |||
There was a problem hiding this comment.
Suggested change
| @ReceiveEvent(components = {ChunkMeshComponent.class, LocationComponent.class}) | |
| @ReceiveEvent(components = {ChunkMeshComponent.class}) |
I think this is better @skaldarnar
There was a problem hiding this comment.
EntityBasedRenderableChunk depends on the existence of a LocationComponent, meaning psudoChunks will never contain an entity which doesn't have a LocationComponent, and that removing it from here would result in reacting to events which don't affect our state.
There was a problem hiding this comment.
BeforeDeactivateComponent is called when a component is removed from an entity. you would get this hit if either LocationComponent or ChunkMeshComponent is removed. I guess in either case this would be valid behavior? would help to have some unit test verify the behavior. the fix is good as it is at the moment.
pollend
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Fixes
ChunkMeshRendererreacting to removals ofMeshComponentinstead ofChunkMeshComponent.